epbs interop branch #14627
Open
epbs interop branch #14627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a helper to get the ptc committee from a state. It uses the cached beacon committees if possible It also implements a helper to compute the largest power of two of a uint64 and a helper to test for nil payload attestation messages
* Add ePBS to db
* Add `remove_flag` and its unit test * Add a test case trying to remove a flag that is not set
* Ensure EPBS state getters and setters check versions * Rename to LatestExecutionPayloadHeaderEPBS * Add minimal beacon state
* Add `IndexedPayloadAttestation` container * Add `GetPayloadAttestingIndices` and its unit test * Add `GetIndexedPayloadAttestation` and its unit test * Add `is_valid_indexed_payload_attestation` and its unit test * Create a smaller set of validators for faster unit test * Pass context to `GetPayloadTimelinessCommittee` * Iterate `ValidatorsReadOnly` instead of copying all validators
* Allow nodes with and without payload in forkchoice
This PR takes care of adding nodes to forkchoice that may or may not
have a corresponding payload. The rationale is as follows
- The node structure is kept almost the same as today.
- A zero payload hash is considered as if the node was empty (except for
the tree root)
- When inserting a node we check what the right parent node would be
depending on whether the parent had a payload or not.
- For pre-epbs forks all nodes are full, no logic changes except a new
steps to gather the parent hash that is needed for block insertion.
This PR had to change some core consensus types and interfaces.
- It removed the ROBlockEPBS interface and added the corresponding ePBS
fields to the ReadOnlyBeaconBlockBody
- It moved the setters and getters to epbs dedicated files.
It also added a checker for `IsParentFull` on forkchoice that simply
checks for the parent hash of the parent node.
* review
* Read only payload attestation message with verifier * Payload attestation tests (#14242) * Payload attestation in verification package * Feedback #1 --------- Co-authored-by: Md Amaan <[email protected]>
* test-added * nil check fix * randomized inputs * hardcoded inputs * suggestions applied * minor-typo fixed * deleted
Adds the processing of execution payload envelope Corrects the protos for attestations and slashings in Electra versions Adds generators of full blocks for Electra
* Payload Attestation Sync package changes * With verifier * change idx back to uint64 * subscribe to topic * add back error --------- Co-authored-by: terence tsao <[email protected]>
* Add getter for payload attestation cache * Check against status * Feedback #1
* Share resources between empty and full nodes - Share a block structure withing the forkchoice node. The surrounding envelope contains information about the payload presence and the children links, the inner structure contains the usual FFG and parent links. - Reworked setOptimistictoInvalid - Changed the PTC vote logic to have validity handled outside of forkchoice and have forkchoice only keep the total count of votes. * Fix tests * gazelle * Update head twice pre-epbs * only upadte best descendants without computing head * skip forkchoice tests * fix some blockchain tests * Nil optimistic sync fix * only count weight of empty nodes
These are some of the things that are left to be done
- Process the payload
- Change stategen to get the poststate of the block and the payload
separately
- Change the next slot cache to be safe for full/empty
* Send FCU on epbs * handle late block tasks * deal with reorgs by attestations * save head on regular sync * don't sleep 1 sec
terencechain
requested review from
rkapka,
nisdas and
james-prysm
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.