Increase Message Limits #14712
Open
Increase Message Limits #14712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
reviewed
Dec 11, 2024
| @@ -18,7 +18,6 @@ var _ NetworkEncoding = (*SszNetworkEncoder)(nil) | |||
| // MaxGossipSize allowed for gossip messages. | |||
| var MaxGossipSize = params.BeaconConfig().GossipMaxSize // 10 Mib. | |||
potuz
reviewed
Dec 11, 2024
| @@ -18,7 +18,6 @@ var _ NetworkEncoding = (*SszNetworkEncoder)(nil) | |||
| // MaxGossipSize allowed for gossip messages. | |||
| var MaxGossipSize = params.BeaconConfig().GossipMaxSize // 10 Mib. | |||
| var MaxChunkSize = params.BeaconConfig().MaxChunkSize // 10 Mib. | |||
potuz
approved these changes
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Comment on lines
+197
to
+199
| // TODO(#14714): remove hard coded sizes once spec is updated | ||
| mnf.MaxChunkSize = 15728640 | ||
| mnf.GossipMaxSize = 15728640 |
There was a problem hiding this comment.
These feel like a temporary spec violation. I'm not sure we should merge & release this until ethereum/consensus-specs#4041 merges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements