Refactor LC handlers Tests #14834
Open
Refactor LC handlers Tests #14834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Jan 29, 2025
|
|
||
| db := dbtesting.SetupDB(t) | ||
| db := dbtesting.SetupDB(t) |
There was a problem hiding this comment.
This can be done once before all tests
|
|
||
| db := dbtesting.SetupDB(t) | ||
| db := dbtesting.SetupDB(t) |
|
|
||
| db := dbtesting.SetupDB(t) | ||
| db := dbtesting.SetupDB(t) |
|
|
||
| updates := make([]interfaces.LightClientUpdate, 2) | ||
| db := dbtesting.SetupDB(t) |
| EnableLightClient: true, | ||
| }) | ||
| defer resetFn() | ||
| db := dbtesting.SetupDB(t) |
Comment on lines
+929
to
+930
| config.MaxRequestLightClientUpdates = 2 | ||
| params.OverrideBeaconConfig(config) |
| }) | ||
|
|
||
| } | ||
| t.Run("start period before altair", func(t *testing.T) { | ||
| db := dbtesting.SetupDB(t) |
| Root: make([]byte, 32), | ||
| })) | ||
| t.Run("missing update in the middle", func(t *testing.T) { | ||
| db := dbtesting.SetupDB(t) |
| signedBlock, err := blocks.NewSignedBeaconBlock(block) | ||
| require.NoError(t, err) | ||
| t.Run("missing update at the beginning", func(t *testing.T) { | ||
| db := dbtesting.SetupDB(t) |
| } | ||
|
|
||
| func TestLightClientHandler_GetLightClientOptimisticUpdateAltair(t *testing.T) { | ||
| func TestLightClientHandler_GetLightClientFinalityUpdate(t *testing.T) { |
There was a problem hiding this comment.
you only have Altair covered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR refactors the light client handlers tests, and bundles them together, to make it easier and cleaner to add more tests.
Which issues(s) does this PR fix?
Part of #12991
Other notes for review
I don't think this PR needs a changelog entry since it's not user-facing and it does not add/remove/change functionality.