Electra e2e minimal #14842
Draft
Electra e2e minimal #14842
+127
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's not merge this yet because it replaces our geth with sina's geth version... sina's branch has something changed for the backend making the output return nil ... |
nisdas
reviewed
Jan 31, 2025
| @@ -760,8 +760,9 @@ def prysm_deps(): | |||
| patches = [ | |||
| "//third_party:com_github_ethereum_go_ethereum_secp256k1.patch", | |||
| ], | |||
| sum = "h1:8hl57x77HSUo+cXExrURjU/w1VhL+ShCTJrTwcCQSe4=", | |||
| version = "v1.14.12", | |||
| replace = "github.com/s1na/go-ethereum", | |||
There was a problem hiding this comment.
This should be a proper release as we will use all the geth packages in production for prysm. Any reason we have to use a geth fork ?
There was a problem hiding this comment.
yeah we should wait but i couldn't test yet I think since it may not have been released, will try to revert to 1.14.13 and try that
There was a problem hiding this comment.
i just tested 1.14.13 and it fails minimal e2e electra is not enabled there only on sina's branch
| @@ -126,6 +126,11 @@ func validatorsParticipating(_ *types.EvaluationContext, conns ...*grpc.ClientCo | |||
| if e2eparams.TestParams.LighthouseBeaconNodeCount != 0 { | |||
| expected = float32(expectedMulticlientParticipation) | |||
| } | |||
| if participation.Epoch == params.BeaconConfig().ElectraForkEpoch { | |||
| // The first slot of Electra will be missed due to the switching of attestation types | |||
There was a problem hiding this comment.
Is this by design ? Why aren't we fixing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Does not
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements