Fix monitor service for Electra #14853
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Electra attestations can include attesting indices from multiple committees, where the committee indices are present in
att.CommitteeBitsVal().BitIndices(). Usingatt.GetData().CommitteeIndexfor an Electra attestation will always return a single0value (which is also wrong for single-committee Electra attestations with a committee other than0).The same method can be used for pre-Electra attestations and the result will be the same as calling
att.GetData().CommitteeIndex. Therefore we can use the same logic for both versions.Acknowledgements