Peer das sync empty requests #14854
Open
Peer das sync empty requests #14854
+25
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
requested review from
rkapka,
nisdas and
dB2510
and removed request for
a team
nalepae
force-pushed
the
peerDAS-sync-empty-requests
branch
from
4553d4a to
f8a7f93
Compare
nalepae
force-pushed
the
peerDAS-sync-empty-requests
branch
from
f8a7f93 to
5ca9288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read commit by commit
Fix edge case where initial sync was blocked because of a bug in the
buildBwbSlicesfunction when, at the same time, we reach the batch limit and the set of missing columns is changing.The first commit adds a new (failing) test case.
The second commit modifies the
buildBwbSlicesto comply with the newsly introduced test case.The other commits are cosmetics.