payload attribute computations in event handler #14963
Open
+208
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py path unit test for code coverage
james-prysm
changed the title
rkapka
reviewed
Mar 4, 2025
| // all of the checked fields empty, so the logical short circuit should hit immediately. | ||
| func needsFill(ev payloadattribute.EventData) bool { | ||
| return ev.HeadState == nil || ev.HeadState.IsNil() || | ||
| ev.HeadState.LatestBlockHeader() == nil || ev.HeadState.LatestBlockHeader() == nil || |
There was a problem hiding this comment.
ev.HeadState.LatestBlockHeader() == nil is checked twice
rkapka
reviewed
Mar 4, 2025
Comment on lines
+177
to
+179
| // the fcu args have differing amounts of completeness based on the code path, | ||
| // and there is work we only want to do if a client is actually listening to the events beacon api endpoint. | ||
| // temporary solution: just fire a blank event and fill in the details in the api handler. |
There was a problem hiding this comment.
Removing the cfg parameter means that in case of firing from notifyForkchoiceUpdate you have to do extra work in the handler, since you need to recompute what you already have available. What about leaving the parameter and filling event data only when cfg != nil? You can then pass nil as the value in lateBlockTasks.
There was a problem hiding this comment.
Doing it this way sidesteps several issues:
- these code paths are already complex and error prone. let's minimize the amount of edge cases that could be coming in from callers that this function needs to anticipate.
- timing concerns that could arise from the node passing into the next slot while the event waits in queue
- concerns around head state being mutated / needing to make a copy
- doing needless work when nothing is actually listening to the event. we have learned that most nodes in the wild are not subscribed to events, so it makes sense to defer all processing until we know the feed has a listener (in the event handler).
Radek's PR suggestion to fix error/log capitalization. Co-authored-by: Radosław Kapka <[email protected]>
rkapka
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This fixes the payload attribute event bugs referenced here:
#14644 (comment)
Other notes for review
Further testing is required, particularly if head is far behind, process_slots can timeout and trigger errors in the event stream response, which may need additional handling.
Acknowledgements