Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LTO flags because it creates artifacts #1137

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

fjtrujy
Copy link
Contributor

@fjtrujy fjtrujy commented Dec 18, 2023

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

The error we are suffering here: #1135 is due of LTO flags.
I have been checking, and the issue actually is in the OPL source code because removing -flto just for the OPL files and keeping the flag in the linker makes the theme to work back.
Most probably the issue is on some optimizations done by the compiler on the "plasma" functions, could be great to find out why this is happening.

Screenshot 2023-12-18 at 08 33 40

Close #1135

Cheers.

@uyjulian uyjulian merged commit c0da23a into master Dec 18, 2023
@uyjulian uyjulian deleted the removeLTOFlag branch December 18, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE]: Default Theme Glitched
2 participants