Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove smsutils dependency (memset and memcpy) #1433

Closed
wants to merge 1 commit into from

Conversation

Wolf3s
Copy link
Contributor

@Wolf3s Wolf3s commented Dec 27, 2024

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

This pr will be merged as soon if network handling error problems is solved.

BEFORE:
OPNPS2LD.ELF(1.337.044 bytes)
AFTER:
OPNPS2LD.ELF(1.337.316 bytes) 

@AKuHAK
Copy link
Member

AKuHAK commented Dec 27, 2024

You should measure the size of the file before and after, cause opl uses specific mem_ functions cause they use less assembler commands

@Wolf3s
Copy link
Contributor Author

Wolf3s commented Dec 27, 2024

You should measure the size of the file before and after, cause opl uses specific mem_ functions cause they use less assembler commands

You should measure the size of the file before and after, cause opl uses specific mem_ functions cause they use less assembler

These specific ones are sms and used by modules but the real problem is sms the custom ones is not being removed.

@Wolf3s
Copy link
Contributor Author

Wolf3s commented Dec 27, 2024

You should measure the size of the file before and after, cause opl uses specific mem_ functions cause they use less assembler commands

Measuring aswell asm files and objs would say aswell.

@Wolf3s
Copy link
Contributor Author

Wolf3s commented Dec 27, 2024

Also i will not open this too soon(I will still consider this as a hack, much of these less calls could added better), But i will put the results now.

@Wolf3s Wolf3s closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants