Limit max BDM UDMA mode to UDMA4 to avoid compatibility issues with various SATA/IDE2SD adapters #1490
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I know UDMA4/UDMA66 was the highest possible UDMA mode supported by the official sony network adapter. Also in their Linux source code. |
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Currently, BDM ATA sets UDMA mode to the highest mode supported by device.
This can completely break HDD support as some SATA and IDE2SD adapters are unstable at speeds higher than UDMA 4, even if the drive itself supports higher UDMA modes.
The most compatible solution is to limit max UDMA mode to 4 to avoid all compatibility issues altogether.
Not to mention that using anything higher provides very minimal benefits that are, in my opinion, are not worth the headache.
Fixes #1437, fixes #1463, fixes #1478.