Skip to content

Conversation

@faltiska
Copy link
Contributor

Also fixed some unit tests that probably fail only on windows.

psiegman and others added 30 commits November 27, 2019 11:41
…siegman#122 Infinite loop</a>.

When reading a file that is not a real zip archive or a zero length file, zipInputStream.getNextEntry() throws an exception and does not advance, so loadResources enters an infinite loop.

I also fixed as many audiot violations as I could in the test class.
… epub declares a language.

They may want to try and detect the language based on the book text if there's no language metadata.
- Handle Scheme
- Handle OPF Resource
- Handle Identifiers
- Be aware of EPUB3
- Creating such kind of books is not supported yet but working with existing books will not fail now.
…publib

� Conflicts:
�	.gitignore
�	epublib-core/pom.xml
�	epublib-core/src/main/java/nl/siegmann/epublib/domain/Author.java
�	epublib-core/src/main/java/nl/siegmann/epublib/domain/Book.java
�	epublib-core/src/main/java/nl/siegmann/epublib/domain/Identifier.java
�	epublib-core/src/main/java/nl/siegmann/epublib/domain/Metadata.java
�	epublib-core/src/main/java/nl/siegmann/epublib/domain/Resource.java
�	epublib-core/src/main/java/nl/siegmann/epublib/domain/Resources.java
�	epublib-core/src/main/java/nl/siegmann/epublib/epub/DOMUtil.java
�	epublib-core/src/main/java/nl/siegmann/epublib/epub/EpubReader.java
�	epublib-core/src/main/java/nl/siegmann/epublib/epub/EpubWriter.java
�	epublib-core/src/main/java/nl/siegmann/epublib/epub/NCXDocument.java
�	epublib-core/src/main/java/nl/siegmann/epublib/epub/PackageDocumentBase.java
�	epublib-core/src/main/java/nl/siegmann/epublib/epub/PackageDocumentMetadataReader.java
�	epublib-core/src/main/java/nl/siegmann/epublib/epub/PackageDocumentMetadataWriter.java
�	epublib-core/src/main/java/nl/siegmann/epublib/epub/PackageDocumentReader.java
�	epublib-core/src/main/java/nl/siegmann/epublib/epub/PackageDocumentWriter.java
�	epublib-core/src/main/resources/dtd/www.daisy.org/z3986/2005/ncx-2005-1.dtd
�	epublib-core/src/test/java/nl/siegmann/epublib/epub/EpubReaderTest.java
�	epublib-core/src/test/java/nl/siegmann/epublib/epub/EpubWriterTest.java
�	epublib-core/src/test/java/nl/siegmann/epublib/epub/PackageDocumentMetadataReaderTest.java
�	epublib-core/src/test/java/nl/siegmann/epublib/epub/PackageDocumentReaderTest.java
�	epublib-core/src/test/java/nl/siegmann/epublib/epub/ResourcesLoaderTest.java
�	epublib-core/src/test/java/nl/siegmann/epublib/epub/Simple1.java
�	epublib-core/src/test/resources/chm1/CHM-example.hhc
�	epublib-core/src/test/resources/chm1/CHM-example.hhk
�	epublib-core/src/test/resources/chm1/Context-sensitive_example/contextID-10000.htm
�	epublib-core/src/test/resources/chm1/Context-sensitive_example/contextID-10010.htm
�	epublib-core/src/test/resources/chm1/Context-sensitive_example/contextID-20000.htm
�	epublib-core/src/test/resources/chm1/Context-sensitive_example/contextID-20010.htm
�	epublib-core/src/test/resources/chm1/Garden/flowers.htm
�	epublib-core/src/test/resources/chm1/Garden/garden.htm
�	epublib-core/src/test/resources/chm1/Garden/tree.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/CloseWindowAutomatically.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/Jump_to_anchor.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/LinkPDFfromCHM.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/Simple_link_example.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/example-external-pdf.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/pop-up_example.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/shortcut_link.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/topic-02.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/topic-03.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/topic-04.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/topic_split_example.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/using_window_open.htm
�	epublib-core/src/test/resources/chm1/HTMLHelp_Examples/xp-style_radio-button_check-boxes.htm
�	epublib-core/src/test/resources/chm1/design.css
�	epublib-core/src/test/resources/chm1/external_files/external_topic.htm
�	epublib-core/src/test/resources/chm1/index.htm
�	epublib-core/src/test/resources/chm1/topic.txt
�	epublib-core/src/test/resources/opf/test2.opf
�	epublib-parent/pom.xml
�	epublib-tools/pom.xml
- NPE when a  <meta refines="#BookId" tag was missing the scheme attribute
- fixed identification of the Relator.AUTHOR tag.

Got rid of many compiler warnings and code audit exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.