-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias all numpy.random functions which PsychoPy imports #581
Open
TEParsons
wants to merge
12
commits into
psychopy:main
Choose a base branch
from
TEParsons:random-utils
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2343a27
Alias numpy.random.random
TEParsons 7f7b791
Fully alias numpy.random.randint
TEParsons 945ef6b
Move random functions together
TEParsons 5e25a00
Placeholder alias for numpy.random.normal
TEParsons 449ac75
Random consistent with randint for handling size
TEParsons 0317047
Document size param
TEParsons 5d75282
Add size to randchoice
TEParsons cd8e06c
Typo
TEParsons c0cab86
Add replace to randchoice
TEParsons bfbcf72
Fully alias numpy.random.choice
TEParsons 4cacf0c
Remove value from weights too if replace is false
TEParsons f6afa65
Splice rather than pop to remove values when replace is false
TEParsons File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also raise errors if given non-integer negative range parameters like this:
randint(-10.1, 1)
will return also a non-integer.Otherwise everything looks good to me.