-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for directed hypergraphs #52
Open
espottesmith
wants to merge
51
commits into
pszufe:master
Choose a base branch
from
espottesmith:directed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graph-based constructor
the opposite capability?
components, but it doesn't work
couldn't immediately figure out for directed hypergraphs
hypergraph thrust
working; annoying but fine because can assign to h.hg_tail or h.hg_head. Making more progress on tests
espottesmith
added a commit
to CoReACTER/SimpleDirectedHypergraphs.jl
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of this PR was to add support for directed hypergraphs to SimpleHypergraphs.jl, directly addressing #45. To do this, I ended up making some abstract types, including AbstractHypergraph, AbstractUndirectedHypergraph, and AbstractDirectedHypergraph, which makes this package more flexible, and I also added the concrete types BasicHypergraph and BasicDirectedHypergraph which don't contain metadata.
I've added tests (I think with good coverage) and updated the docs. I have not created an example or tutorial yet.