Enforce the egg's file denylist more thoroughly #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsvic-dev
force-pushed
the
itsvic/apply-denylist-thoroughly
branch
from
24df8d2 to
e7139a9
Compare
|
@itsvic-dev Are the files still shown in the file manager but you can just not download or open them (and sftp) or are they just fully hidden? |
It's been a while, but IIRC the files are shown in the file manager but not readable or writable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file denylist is not strictly enforced since Wings v1.11.9+. This PR adds extra checks where relevant to make sure that the file denylist is respected more appropriately.
Closes pterodactyl/panel#5042.