Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYNAREC] Appended instruction name to symbol #2228

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

xiangzhai
Copy link
Contributor

Hi,

To find benchmark some workload high branch-misses:

export BOX64_DYNAREC_PERFMAP=1
perf record -e branches -e branch-misses box64 scimark4-x64

To find Symbol 0x000000fff5417170 around:

Samples: 22K of event 'branch-misses:u', Event count (approx.): 225354432
Overhead  Command       Shared Object          Symbol
  29.42%  scimark4-x64  perf-22759.map         [.] 0x000000fff5417174
  29.02%  scimark4-x64  perf-22759.map         [.] 0x000000fff5417170

There might be some opportunity to reduce the branch-misses:

...
0xfff5417160 2 Random_nextDouble:TEST Ed, Gd
0xfff5417168 4 Random_nextDouble:CMOVS Gd, Ed
0xfff5417178 1 Random_nextDouble:TEST Ed, Gd
0xfff541717c 1 Random_nextDouble:MOV Ed, Gd
...

Please review my patch.

Thanks,
Leslie Zhai

@ptitSeb
Copy link
Owner

ptitSeb commented Jan 1, 2025

Are you sure it's usefull to have this level of detail there? it will make map files much bigger, so it better be usefull!

@xiangzhai
Copy link
Contributor Author

Are you sure it's usefull to have this level of detail there?

Yup, I am looking for context such as below might lead high branch-misses:

FCMPxxx
BCEQ|NEZ
...

it will make map files much bigger

Yup, but it is able to split the workloads into smaller one, for example, only perf record scimark's MonteCarlo, the map file size is around 31K.

Thanks,
Leslie Zhai

@ptitSeb ptitSeb merged commit 4065e61 into ptitSeb:main Jan 3, 2025
27 checks passed
@xiangzhai
Copy link
Contributor Author

Thanks 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants