Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows either strings or bytes to be supplied as input to the constructor and methods such as
lcs()
.To avoid errors in operations with conflicting types, the input type is stored and checked when necessary, under field
input_type
.One inconvenient of handling raw bytes is that the terminal symbol becomes a multi-byte sequence (e.g. 3 bytes) when converted from the generated unicode char. Some conditionals were adapted to handle this larger terminal symbol length. One function used in those conditionals is
_suffix_contains_terminal_symbol()
. The validations on this function handle some cases I stumbled upon (e.g. suffixes with 2 bytes from the terminal symbol; suffixes with one original byte plus 2 bytes from the terminal symbol). Feel free to suggest an alternative approach if you want something more robust.