Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for raw bytes input #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nevesnunes
Copy link

@nevesnunes nevesnunes commented Aug 5, 2020

This pull request allows either strings or bytes to be supplied as input to the constructor and methods such as lcs().

To avoid errors in operations with conflicting types, the input type is stored and checked when necessary, under field input_type.

One inconvenient of handling raw bytes is that the terminal symbol becomes a multi-byte sequence (e.g. 3 bytes) when converted from the generated unicode char. Some conditionals were adapted to handle this larger terminal symbol length. One function used in those conditionals is _suffix_contains_terminal_symbol(). The validations on this function handle some cases I stumbled upon (e.g. suffixes with 2 bytes from the terminal symbol; suffixes with one original byte plus 2 bytes from the terminal symbol). Feel free to suggest an alternative approach if you want something more robust.

@nevesnunes
Copy link
Author

I'm still interested in getting this feature merged, but I need some clarification before investing time fixing these tests:

  • Is this repository abandoned? If so, please mark it as archived.
  • Is my implemented approach valid, or would significant changes be required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant