Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't overwrite namespaces when importing rules in existing ones #17

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

Clemog
Copy link
Contributor

@Clemog Clemog commented Jul 5, 2024

Fix #16

We consider now all files for duplicates check from getModelFromSource

@Clemog Clemog requested a review from EmileRolley July 5, 2024 12:05
Copy link
Collaborator

@EmileRolley EmileRolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'appel de getModelFromSource sur toutes les fichiers du modèle NGC prend sur ma machine ~100ms (au lieu de ~14ms actuellement). De plus, la résolution des imports est déjà faite pour chacun des fichiers. Je propose donc un fix différent qui ignore les namespaces des règles importés s'il existe déjà.

Je serai également d'avis de rajouter un warning car ce n'est pas une pratique qu'il me semble bonne à mettre en avant. En effet, on préférera utiliser des namespaces unique pour les règles importées afin d'éviter toutes confusions ou écrasements.

@EmileRolley EmileRolley changed the title fix: use getModelFromSource on all files fix: don't overwrite namespaces when importing rules in existing ones Jul 6, 2024
@EmileRolley EmileRolley added bug Something isn't working server labels Jul 6, 2024
@Clemog
Copy link
Contributor Author

Clemog commented Jul 8, 2024

D'acc merci :)

@Clemog Clemog merged commit ef3d6f2 into main Jul 8, 2024
1 check passed
@EmileRolley EmileRolley deleted the fix-raw-rules-parsing branch July 8, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown undefined logement rule in NGC model
2 participants