Feat(optim)!: rewrite of the constant folding pass #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmileRolley
added
✨ enhancement
EmileRolley
force-pushed
the
optim-v2
branch
6 times, most recently
from
8ec176c to
369fc00
Compare
@EmileRolley j'ai tenté un truc mais le souci c'est qu'on n'a plus dans la règle qu'on ne doit pas optimiser l'info du recalcul/context mais seulement via le parent, règle par laquelle on passe "trop" tard
J'ai raconté n'importe quoi dans mon dernier commit ! 😶
Pas sur que ce soit utile mais j'ai toujours une erreur avec l'optim alors que tous les tests passent ici :/
This reverts commit 6447efc.
EmileRolley
force-pushed
the
optim-v2
branch
from
099e262 to
a2a0d54
Compare
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to serialize parsed rules which facilitate the substitution of constants. Furthermore, the rewrite allows to identify and fixes previous problematic behaviors in the previous constant folding pass (e.g. be aware of the rule's contexte, and conditional applicability of namespaces).