refactor!: simplification of the migrateSituation code #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmileRolley
changed the title
EmileRolley
force-pushed
the
migration-refactoring
branch
from
7a5efb5 to
8ca0930
Compare
EmileRolley
force-pushed
the
migration-refactoring
branch
from
8ca0930 to
b8c03be
Compare
EmileRolley
force-pushed
the
migration-refactoring
branch
from
b8c03be to
6c73142
Compare
Clemog
reviewed
Jun 3, 2024
Clemog
reviewed
Jun 3, 2024
Clemog
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global refactoring of the migration code by harmonizing code conventions (file structure, naming, etc..) and by simplifying the API: only migrate situations (as folded steps can easily be map into a situation and it's specific to NGC).