Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SQLAlchemy to version 2 #415

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Commits on Jan 30, 2023

  1. tests: fix bug when calling exists method

    exists is a method, so prior to change, assert would always pass
    
    thankfully, this still works on sqlalchemy 1.4 after change
    karlicoss committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    4491da4 View commit details
    Browse the repository at this point in the history
  2. tests: prepare for migrating away from deprecated has_table method

    seems that table.table.exists() actually created table
    
    if we replace it with self.db_has_table instead, it doesn't work
    I assume because it works on sqlalchemy metadata level and not issuing actual sql engine commands
    
    to demonstrate that I've put the asserts with self.db.has_table in setUp method
    
    for now just removed the assert from test_create_table_shorthand* tests
    karlicoss committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    73f59e1 View commit details
    Browse the repository at this point in the history
  3. some work towards making compatible with sqlalchemy 2.0

    passes all tests on sqlalchemy 1.4
    karlicoss committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    fc11118 View commit details
    Browse the repository at this point in the history
  4. debug

    karlicoss committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7fdf348 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. upgrade to SQLAlchemy version 2

    all tests passed
    M4rque2 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    3f6550b View commit details
    Browse the repository at this point in the history