Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enumerate the OCI_ENV_PATH automatically. #128

Merged
merged 15 commits into from
Jul 31, 2023
Merged

Enumerate the OCI_ENV_PATH automatically. #128

merged 15 commits into from
Jul 31, 2023

Conversation

jctanner
Copy link
Contributor

Forgetting to set OCI_ENV_PATH or not setting it correctly is a pain point with using oci-env.

@jctanner
Enumerate the OCI_ENV_PATH automatically.
aed3d63 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
Docker compose install is broken in github.
2520912 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
Try CI without setting OCI_ENV_PATH ...
32b60a8 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
Debug prints.
8a6dbc9 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
More debug.
1aec259 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
More debug.
08a53b1 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
More debug ...
9ac4f81 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
Traling slash?
fad68f4 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
Try this?
d5a8cd4 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
Use logzero.
85033e6 
[noissue]

Signed-off-by: James Tanner <[email protected]>
decko
decko reviewed Jul 26, 2023
View reviewed changes
client/oci_env/utils.py Outdated Show resolved Hide resolved
gerrod3
gerrod3 reviewed Jul 26, 2023
View reviewed changes
client/oci_env/utils.py Outdated Show resolved Hide resolved
gerrod3
gerrod3 reviewed Jul 26, 2023
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@jctanner
Use stdlib logger.
908c6a5 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
Review changes.
95893d7 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
Remove unused workflow step.
813932b 
[noissue]

Signed-off-by: James Tanner <[email protected]>
gerrod3
gerrod3 requested changes Jul 27, 2023
View reviewed changes
client/oci_env/utils.py Outdated Show resolved Hide resolved
client/oci_env/utils.py Outdated Show resolved Hide resolved
client/oci_env/utils.py Outdated Show resolved Hide resolved
client/oci_env/logger.py Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@jctanner
Cleanup.
2819e68 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner requested a review from gerrod3 July 27, 2023 19:58
newswangerd
newswangerd approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@newswangerd newswangerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! Just clean up the trailing slashes and you're good to go

client/oci_env/logger.py Show resolved Hide resolved
client/oci_env/utils.py Show resolved Hide resolved
@jctanner
No trailing slashes.
89adaa9 
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner merged commit e73d367 into pulp:main Jul 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decko decko decko approved these changes

@newswangerd newswangerd newswangerd approved these changes

@gerrod3 gerrod3 gerrod3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jctanner @decko @newswangerd @gerrod3