Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openapi module plugins installation on venv #67

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix openapi module plugins installation on venv #67

merged 1 commit into from
Jul 4, 2024

Conversation

pedro-psb
Copy link
Member

#59 was merged with some errors on venv setups:

  • pulpcore was being installed explicitly, but that was not necessary as its already a plugin dependency.
  • pulpcore was being installed from pypi, while other plugins were being installed from git.

@pedro-psb pedro-psb requested a review from mdellweg July 4, 2024 12:39
@pedro-psb pedro-psb merged commit a6d5f24 into pulp:main Jul 4, 2024
4 checks passed
@pedro-psb pedro-psb deleted the fix-openapi-module-venv-installations branch July 4, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro-psb @mdellweg