-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ansible] csv: Fix file_storage_access_mode enum #950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
/approve cancel |
are not you supposed to update this file too? https://github.com/pulp/pulp-operator/blob/ansible/bundle/manifests/pulp-operator.clusterserviceversion.yaml#L605 |
you're absolutely right, I forgot to update the generated CSV file |
When using the UI, there's only the ReadWriteMany value available for the file_storage_access_mode parameter. ReadWriteOnce is also an available option. https://github.com/pulp/pulp-operator/blob/ansible/config/crd/bases/pulpproject_v1beta1_pulp_crd.yaml#L159-L165 [noissue] Signed-off-by: Dimitri Savineau <[email protected]>
2514bf1
to
a20c05b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsavineau, ipanova The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When using the UI, there's only the ReadWriteMany value available for the file_storage_access_mode parameter.
ReadWriteOnce is also an available option.
https://github.com/pulp/pulp-operator/blob/ansible/config/crd/bases/pulpproject_v1beta1_pulp_crd.yaml#L159-L165
[noissue]