Repository navigation
Revert content query optimization and experiment commits - #1652
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReverts the read-only content query optimization and interval-content/content-membership experiment work by removing its image patches, documentation, change notes, runtime dispatch helper, and associated tests; the existing query behavior and experiment infrastructure remain in place. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="Dockerfile" line_range="190-192" />
<code_context>
COPY images/assets/patches/0079-Log-Maven-path-index-fallback-reasons.patch /tmp/
RUN patch -p1 -d /usr/local/lib/pulp/lib/python${PYTHON_VERSION}/site-packages < /tmp/0079-Log-Maven-path-index-fallback-reasons.patch
-COPY images/assets/patches/0080-Optimize-read-only-content-queries.patch /tmp/
-RUN patch -p1 -d /usr/local/lib/pulp/lib/python${PYTHON_VERSION}/site-packages < /tmp/0080-Optimize-read-only-content-queries.patch
-
-COPY images/assets/patches/0081-Experiment-interval-content-query.patch /tmp/
-RUN patch -p1 -d /usr/local/lib/pulp/lib/python${PYTHON_VERSION}/site-packages < /tmp/0081-Experiment-interval-content-query.patch
</code_context>
<issue_to_address>
**Revert lacks release notes**
When this non-trivial revert is merged, the revert has no release-note entry: it deletes the two existing fragments and adds no replacement, so the change is missing from the project’s release notes.
Add a towncrier fragment describing the revert.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: Dockerfile:192
| COPY images/assets/patches/0080-Optimize-read-only-content-queries.patch /tmp/ | ||
| RUN patch -p1 -d /usr/local/lib/pulp/lib/python${PYTHON_VERSION}/site-packages < /tmp/0080-Optimize-read-only-content-queries.patch | ||
|
|
There was a problem hiding this comment.
🟡 Medium · Revert lacks release notes
When this non-trivial revert is merged, the revert has no release-note entry: it deletes the two existing fragments and adds no replacement, so the change is missing from the project’s release notes.
Add a towncrier fragment describing the revert.
Prompt for AI agents
In `Dockerfile` at lines 190-192:
**Revert lacks release notes**
When this non-trivial revert is merged, the revert has no release-note entry: it deletes the two existing fragments and adds no replacement, so the change is missing from the project’s release notes.
Add a towncrier fragment describing the revert.From CLAUDE.md L76:
Uses **towncrier**. For any non-trivial change, create a file in `CHANGES/` named `{issue_number}.{category}` where category is one of: `feature`, `bugfix`, `doc`, `removal`, `deprecation`, `misc`.
Reverts two commits related to the read-only content query optimization and content membership experiments:
Reverted in that order (newest first) to avoid conflicts. Both applied cleanly.
🤖 Generated with Claude Code
Summary by Sourcery
Revert the read-only content query optimization and content membership experiment changes.
Enhancements:
Build:
Documentation:
Tests:
Chores: