Skip to content

Revert content query optimization and experiment commits - #1652

Merged
dkliban merged 2 commits into
pulp:mainfrom
dkliban:revert-content-experiments
Oct 29, 2026
Merged

dkliban merged 2 commits into
pulp:mainfrom
dkliban:revert-content-experiments

Conversation

@dkliban

@dkliban dkliban commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Reverts two commits related to the read-only content query optimization and content membership experiments:

Reverted in that order (newest first) to avoid conflicts. Both applied cleanly.

🤖 Generated with Claude Code

Summary by Sourcery

Revert the read-only content query optimization and content membership experiment changes.

Enhancements:

  • Remove the read-only content query optimization and interval content experiment from the service and container build.

Build:

  • Stop applying the patches that enabled the read-only content query optimization and interval content experiment in the Docker image.

Documentation:

  • Remove the interval content query test plan.

Tests:

  • Remove the interval content experiment unit tests.

Chores:

  • Remove the associated changelog entries and experiment dispatch support.

@sourcery-ai

sourcery-ai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Reverts the read-only content query optimization and interval-content/content-membership experiment work by removing its image patches, documentation, change notes, runtime dispatch helper, and associated tests; the existing query behavior and experiment infrastructure remain in place.

File-Level Changes

Change Details Files
Remove the Docker build integration for the read-only content query optimization and interval-content experiment patches.
  • Stop copying and applying both optimization patches during image construction.
  • Remove the associated change-log entries and interval-content test plan.
Dockerfile
CHANGES/1996.misc
CHANGES/2346.bugfix
docs/test_plans/0005-Interval_Content_Query.md
images/assets/patches/0080-Optimize-read-only-content-queries.patch
images/assets/patches/0081-Experiment-interval-content-query.patch
Revert the lazy experiment dispatch functionality used for content membership experimentation.
  • Delete lazy queryset experiment selection and dispatch logging, including repository and correlation metadata.
  • Remove the dedicated interval-content experiment unit tests.
pulp_service/pulp_service/app/experiments.py
pulp_service/pulp_service/tests/unit/test_interval_content_experiment.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="Dockerfile" line_range="190-192" />
<code_context>
 COPY images/assets/patches/0079-Log-Maven-path-index-fallback-reasons.patch /tmp/
 RUN patch -p1 -d /usr/local/lib/pulp/lib/python${PYTHON_VERSION}/site-packages < /tmp/0079-Log-Maven-path-index-fallback-reasons.patch

-COPY images/assets/patches/0080-Optimize-read-only-content-queries.patch /tmp/
-RUN patch -p1 -d /usr/local/lib/pulp/lib/python${PYTHON_VERSION}/site-packages < /tmp/0080-Optimize-read-only-content-queries.patch
-
-COPY images/assets/patches/0081-Experiment-interval-content-query.patch /tmp/
-RUN patch -p1 -d /usr/local/lib/pulp/lib/python${PYTHON_VERSION}/site-packages < /tmp/0081-Experiment-interval-content-query.patch
</code_context>
<issue_to_address>
**Revert lacks release notes**

When this non-trivial revert is merged, the revert has no release-note entry: it deletes the two existing fragments and adds no replacement, so the change is missing from the project’s release notes.

Add a towncrier fragment describing the revert.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: Dockerfile:192


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread Dockerfile
Comment on lines -190 to -192
COPY images/assets/patches/0080-Optimize-read-only-content-queries.patch /tmp/
RUN patch -p1 -d /usr/local/lib/pulp/lib/python${PYTHON_VERSION}/site-packages < /tmp/0080-Optimize-read-only-content-queries.patch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Revert lacks release notes

When this non-trivial revert is merged, the revert has no release-note entry: it deletes the two existing fragments and adds no replacement, so the change is missing from the project’s release notes.

Add a towncrier fragment describing the revert.

Prompt for AI agents
In `Dockerfile` at lines 190-192:

**Revert lacks release notes**

When this non-trivial revert is merged, the revert has no release-note entry: it deletes the two existing fragments and adds no replacement, so the change is missing from the project’s release notes.

Add a towncrier fragment describing the revert.

From CLAUDE.md L76:

Uses **towncrier**. For any non-trivial change, create a file in `CHANGES/` named `{issue_number}.{category}` where category is one of: `feature`, `bugfix`, `doc`, `removal`, `deprecation`, `misc`.

@dkliban
dkliban merged commit 2c4e0e2 into pulp:main Oct 29, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant