Repository navigation
Bump dev container to Python 3.12 - #1676
Merged
Merged
Conversation
pulp-python 3.37.0+ requires Python >=3.12. Since pulp#1671 pinned pulp-python==3.38.0, the dev container image (still on Python 3.11) fails to build at `pip install /tmp/pulp_service`. The production Dockerfile already uses 3.12. - dev-container/Dockerfile: PYTHON_VERSION 3.11 -> 3.12 - pulp-add-patch / pulp-remove-patch: update site-packages fallback - setup.py: python_requires >=3.12, drop 3.11 classifier Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the development environment and pulp-service metadata to Python 3.12, resolving installation incompatibility with pulp-python 3.38.0 while matching the production container’s Python version. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
hosted-pulp-dev-envimage build onmainfails since #1671 pinnedpulp-python==3.38.0:dev-container/Dockerfilestill uses Python 3.11, but pulp-python 3.37.0 and later require Python 3.12 or newer. The productionDockerfilealready uses 3.12, so only the dev container broke.Changes
dev-container/Dockerfile:PYTHON_VERSION3.11 → 3.12 (matches production)dev-container/scripts/pulp-add-patch/pulp-remove-patch: site-packages fallback path → 3.12pulp_service/setup.py:python_requires=">=3.12", drop the 3.11 classifier🤖 Generated with Claude Code
Summary by Sourcery
Update the development environment and package requirements to Python 3.12.
Bug Fixes:
Enhancements: