Skip to content

Bump dev container to Python 3.12 - #1676

Merged
YasenT merged 1 commit into
pulp:mainfrom
YasenT:fix-dev-container-python312
Nov 6, 2026
Merged

YasenT merged 1 commit into
pulp:mainfrom
YasenT:fix-dev-container-python312

Conversation

@YasenT

@YasenT YasenT commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The hosted-pulp-dev-env image build on main fails since #1671 pinned pulp-python==3.38.0:

ERROR: Ignored the following versions that require a different python version: 3.37.0 Requires-Python >=3.12; 3.37.1 Requires-Python >=3.12; 3.38.0 Requires-Python >=3.12
ERROR: No matching distribution found for pulp-python==3.38.0 (from pulp-service)

dev-container/Dockerfile still uses Python 3.11, but pulp-python 3.37.0 and later require Python 3.12 or newer. The production Dockerfile already uses 3.12, so only the dev container broke.

Changes

  • dev-container/Dockerfile: PYTHON_VERSION 3.11 → 3.12 (matches production)
  • dev-container/scripts/pulp-add-patch / pulp-remove-patch: site-packages fallback path → 3.12
  • pulp_service/setup.py: python_requires=">=3.12", drop the 3.11 classifier

🤖 Generated with Claude Code

Summary by Sourcery

Update the development environment and package requirements to Python 3.12.

Bug Fixes:

  • Restore dev-container builds and compatibility with pulp-python releases requiring Python 3.12 or newer.

Enhancements:

  • Align the development container and pulp-service package metadata with Python 3.12.
  • Update development scripts to use the Python 3.12 site-packages path.

pulp-python 3.37.0+ requires Python >=3.12. Since pulp#1671 pinned
pulp-python==3.38.0, the dev container image (still on Python 3.11)
fails to build at `pip install /tmp/pulp_service`. The production
Dockerfile already uses 3.12.

- dev-container/Dockerfile: PYTHON_VERSION 3.11 -> 3.12
- pulp-add-patch / pulp-remove-patch: update site-packages fallback
- setup.py: python_requires >=3.12, drop 3.11 classifier

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the development environment and pulp-service metadata to Python 3.12, resolving installation incompatibility with pulp-python 3.38.0 while matching the production container’s Python version.

File-Level Changes

Change Details Files
Align the development container and package metadata with the Python version required by current pulp-python dependencies.
  • Raise the dev-container base Python version from 3.11 to 3.12.
  • Update patch helper fallback paths to the Python 3.12 site-packages location.
  • Require Python 3.12 or newer and remove the Python 3.11 package classifier.
dev-container/Dockerfile
dev-container/scripts/pulp-add-patch
dev-container/scripts/pulp-remove-patch
pulp_service/setup.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@YasenT
YasenT merged commit 8bd6cd3 into pulp:main Nov 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant