-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the outdated information from the docs #5889
Conversation
52d7dbd
to
81bd108
Compare
Inspired by https://github.com/pulp/pulp-cli/blob/main/releasing.md (which is easy to find and follow). |
c2f7a5a
to
1625b71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a fan of keeping the information with the code. In this case, I guess the "release.md" should come with the template.
MANIFEST.in
Outdated
@@ -15,3 +15,4 @@ include COPYRIGHT | |||
include pulpcore/app/templates/rest_framework/api.html | |||
include manage.py | |||
include test_requirements.txt | |||
include RELEASING.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, let's ignore and not include this file in the published artifacts.
RELEASING.md
Outdated
``` | ||
|
||
### Create a New Y-branch of Pulpcore (e.g., 3.23) | ||
- If needed, trigger a [Create New Release Branch](https://github.com/pulp/pulpcore/actions/workflows/create-branch.yml) job via the GitHub Actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates the bump version PR. That one needs to be watched and prioritised.
|
||
ACS support is provided as a tech preview in pulp_file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes warrant for at least a separate commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found these to be a leftover after merging pulp-file into pulpcore.
3ee7d06
to
19661e5
Compare
Good idea. However, how can we ensure that this file is shipped together with the |
I think it should go in the templated section. The plugin template repo does not want to have a "How to release" document for itself. |
19661e5
to
0f85687
Compare
The initial change should be now shipped through the plugin template, please review: pulp/plugin_template#919. I still think the proposed removals should be merged. |
No description provided.