Merge branch 'master' into v1.110.0-release

pulsar-edit · Oct 16, 2023 · 53d3ce2 · 53d3ce2
2 parents 24f3df7 + 8625b77
commit 53d3ce2
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/packages/wrap-guide/lib/wrap-guide-element.js b/packages/wrap-guide/lib/wrap-guide-element.js
@@ -90,8 +90,10 @@ module.exports = class WrapGuideElement {
       const columns = uniqueAscending(args.newValue);
       if (columns != null ? columns.length : undefined) {
         atom.config.set('wrap-guide.columns', columns);
-        atom.config.set('editor.preferredLineLength', columns[columns.length - 1],
-          {scopeSelector: `.${this.editor.getGrammar().scopeName}`});
+        if (atom.config.get('wrap-guide.modifyPreferredLineLength')) {
+          atom.config.set('editor.preferredLineLength', columns[columns.length - 1],
+            {scopeSelector: `.${this.editor.getGrammar().scopeName}`});
+        }
         return this.updateGuide();
       }
     };

diff --git a/packages/wrap-guide/package.json b/packages/wrap-guide/package.json
@@ -17,6 +17,11 @@
       },
       "description": "Display guides at each of the listed character widths. Leave blank for one guide at your `editor.preferredLineLength`."
     },
+    "modifyPreferredLineLength": {
+      "default": true,
+      "type": "boolean",
+      "description": "Modify the Editor's Preferred Line Length when changing Wrap Guide's Columns setting."
+    },
     "enabled": {
       "default": true,
       "type": "boolean"

diff --git a/packages/wrap-guide/spec/wrap-guide-element-spec.js b/packages/wrap-guide/spec/wrap-guide-element-spec.js
@@ -105,7 +105,7 @@ describe("WrapGuideElement", function() {
       for (let i = 0; i < columnCount; i++) {
         columns.push(i * 10);
       }
-      
+
       atom.config.set("wrap-guide.columns", columns);
       waitsForPromise(() => editorElement.getComponent().getNextUpdatePromise());
 
@@ -245,6 +245,19 @@ describe("WrapGuideElement", function() {
         expect(wrapGuide).toBeVisible();
       });
     });
+
+    it("leaves alone preferredLineLength if modifyPreferredLineLength is false", () => {
+      const initial = atom.config.get("editor.preferredLineLength", { scope: editor.getRootScopeDescriptor() });
+      atom.config.set("wrap-guide.modifyPreferredLineLength", false);
+
+      atom.config.set("wrap-guide.columns", [ initial, initial + 10]);
+      waitsForPromise(() => editorElement.getComponent().getNextUpdatePromise());
+
+      runs(() => {
+        const length = atom.config.get("editor.preferredLineLength", { scope: editor.getRootScopeDescriptor() });
+        expect(length).toBe(initial);
+      });
+    });
   });
 
   describe("when the editor's scroll left changes", () => it("updates the wrap guide position to a relative position on screen", function() {