Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update GitHub Token in CirrusCI config #1134

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

confused-Techie
Copy link
Member

The token expired today, and wanted to ensure it was updated prior to release activities

@confused-Techie confused-Techie changed the title Update GitHub Token [ci] Update GitHub Token in CirrusCI config Nov 14, 2024
Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for updating this token.

@DeeDeeG
Copy link
Member

DeeDeeG commented Nov 17, 2024

Almost definitely unrelated to .cirrus.yml and this PR: Not sure why electron-builder can't build bins on macOS? For PR's it's not trying to sign binaries, so this is something else...

  • building        target=macOS zip arch=x64 file=dist/Pulsar-1.122.2024111522-mac.zip
  • building        target=DMG arch=x64 file=dist/Pulsar-1.122.2024111522.dmg
  • building block map  blockMapFile=dist/Pulsar-1.122.2024111522-mac.zip.blockmap
  • Above command failed, retrying 5 more times

Maybe It's actually failing to build a blockmap, for some reason? We don't even use the blockmap (which is for auto-updates to not need to fetch more bits if any are redundant across releases)... I wonder if we can skip trying to create a blockmap. Or otherwise figure out what's going on here.

Technically this is timing out repeatedly, but there is also the "command failed, retrying 5 more times", which... I don't remember seeing before, but to be fair I don't expressly remember not seeing it either. It's loosely possible increasing the nick-fields/retry action timeout might just fix/workaround this? Currently it's set to a 45 minute timeout... Hmmmmmb. 🤔

@DeeDeeG
Copy link
Member

DeeDeeG commented Nov 18, 2024

Merging now. Thanks again.

I will ponder the CI issue elsewhere, if it persists.

@DeeDeeG DeeDeeG merged commit ebde801 into master Nov 18, 2024
102 of 103 checks passed
@confused-Techie
Copy link
Member Author

Thanks for merging @DeeDeeG.
I'll see if I can dig up anything on the macOS failure. But here's hoping the next PR doesn't see this

@confused-Techie confused-Techie deleted the confused-Techie-patch-1 branch November 19, 2024 00:06
@DeeDeeG
Copy link
Member

DeeDeeG commented Nov 19, 2024

Hi, see #1137 for what I believe should address the CI issue we're seeing on macOS.

No idea why this only hit now, or why only on macOS, but race conditions do be unpredictable. So there. May as well eliminate the chance for one to occur! Hence #1137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants