CI: Add build dependencies for Linux 'test bins' job #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeDeeG
force-pushed
the
install-missing-deps-for-test-and-upload-Linux-job
branch
2 times, most recently
from
0528d37 to
958de1a
Compare
Need to fix a compilation error in CI which is resulting from missing X11-related headers. Some of these deps presumably have been removed or changed in the recent "ubuntu-latest means Ubuntu 24.04" change. See this tracking issue about the runner migration for details, maybe: github[dot]com/actions[slash]runner-images/issues/10636 So, adding all of these deps just to be sure our code can compile and be tested successfully in CI. These are the same deps as used above in the main "build" Linux part of the workflow file.
DeeDeeG
force-pushed
the
install-missing-deps-for-test-and-upload-Linux-job
branch
from
958de1a to
c3a4a9d
Compare
DeeDeeG
changed the title
confused-Techie
approved these changes
Dec 16, 2024
DeeDeeG
force-pushed
the
install-missing-deps-for-test-and-upload-Linux-job
branch
from
bb937ed to
b3a6042
Compare
|
Last second force push to reflect the better PR title in the Changelog (done) |
confused-Techie
deleted the
install-missing-deps-for-test-and-upload-Linux-job
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There is a compilation error in the
test-and-upload-Linuxjob of the "Build Pulsar binaries" workflow:(Thank you to @savetheclocktower for noticing and reporting this!!)
Context
Some of these dependencies presumably have been removed or changed in the recent "ubuntu-latest means Ubuntu 24.04" change.
See this tracking issue about the runner migration for details, maybe: github[dot]com/actions/runner-images/issues/10636
Fix
Add the same various
aptdependencies to theupload-and-test-Linuxjob as we install in the main "Build binaries" job on Linux, for this workflow.Verification Process
Kinda need to see the "Build pulsar binaries" CI job pass to the point of the
test-and-upload-Linuxjob running (and hopefully, passing).