CI: Retry on timeout when building macOS bins #1178
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, adjust the timeout duration to be shorter, and adjust the number of retries to be greater. I figure successful runs usually succeed quickly (~27 minutes or less?) So, get to the retrying faster! But also, let's actually retry, a bunch more times if we have to!
37 minutes is a bit long. 31 minutes should allow most runs that are *going* to finish to finish, without wasting more time than we need to waiting for runs that are hung and are never going to finish anyway. Considered 27, since *most* runs finish at 16 minutes, and all but one of my ~11 test runs were under 27 minutes, but *one* of my test runs was just under 31 minutes, so this should do the trick. Having to wait for an entire additional run by being over-eager to retry (too impatient) feels wasteful and not the best trade-off. Anyhow, this is closer to the right number, even if picking a better "exact ideal timeout" may be possible, this is close enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: Retry on timeout when building macOS bins
Also, adjust the timeout duration to be shorter, and adjust the number of retries to be greater.
I figure successful runs usually succeed quickly (~27 minutes or less?). So, get to the retrying faster! But also, let's actually retry, a bunch more times if we have to!
[Testing testing, this is a draft to put CI through it's paces, to try and see if this is the right approach. Should be run at busy times of day, such as toward the end of a typical working day in the Americas time zones.]