[core] Windows: Only remove Pulsar/PPM from PATH during uninstall #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1157
When I originally wrote the section of our NSIS that removes Pulsar from the PATH during uninstallation, I was aware that this code would also be run during an upgrade, since the upgrade process uninstalls the old version then installs the new.
But I was under the impression that those steps were linear, running uninstallation steps then running installation steps.
But it seems that isn't the case. Meaning that even though the installation steps would add items to the PATH, our custom uninstallation steps were run afterwards, ultimately removing Pulsar/PPM from the PATH.
Luckily,
electron-buildermakes it easy to check if we are running an upgrade rather than a full uninstall. Meaning we can check how we are running, and only remove items from the PATH during a complete uninstall.