Add missing shell methods on atom global#1564
Open
savetheclocktower wants to merge 4 commits into
Open
Conversation
Daeraxa
reviewed
May 19, 2026
Member
|
I tried them all out in the dev tools console and they seem to work fine. Even substituted the Also checked that |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1563.
This adds in the following methods:
atom.trashItematom.openPathatom.openExternalatom.showItemInFolderAll of these exist on
require('electron').shell, but are not 100% able to be called from the renderer for one reason or another. As with many other methods defined on theatomglobal, these methods proxy to the main process via IPC, then receive the outcome from the main process.Specs are present for
atom.trashItem, but I've got no clue how I'd test the others. That'll require manual testing.