Fix: Add UI scrollbar variable fallbacks#1566
Merged
savetheclocktower merged 2 commits intoMay 20, 2026
Merged
Conversation
This was referenced May 19, 2026
savetheclocktower
approved these changes
May 20, 2026
Contributor
savetheclocktower
left a comment
savetheclocktower
left a comment
There was a problem hiding this comment.
Perfect. Thanks!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pulsar-edit/terminal#30 and #1565
terminalspecifies:But it seems prior to adding
terminalto core, these were only ever needed as variables within the inbuilt themes and so had no fallback.This adds what I think are some sane fallbacks based on a couple of themes I looked at so that they don't look obviously wrong. At the very least it doesn't cause Pulsar to freak out when starting.