Bugfix for repo command and cert signing#94
Merged
tianyuan129 merged 3 commits intopulsejet:mainfrom Dec 31, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR (repo commands are signed by user's testbed cert #93) did not correctly change the behavior of repo command signing. Repo commands are actually encapsulated as Data within Interests, and the signer was therefore not updated as intended. This PR fixes the bug and verifies that the repo command signer now changes correctly.
Added automatic renewal (maybe resigning is a better term) of the user workspace certificate. Previously, only the user testbed certificate was periodically renewed and its downstream remained, causing the authentication chain of user workspace data to still trace back to an outdated testbed certificate.