Skip to content

Conversation

@kimberleyamackenzie
Copy link
Contributor

Proposed changes

Unreleased product version (optional)

Related issues (optional)

@claude
Copy link
Contributor

claude bot commented Nov 13, 2025

Documentation Review

I've reviewed the changes in this PR that align colors with Console color tokens. Here are my findings:

Issues Found

1. Missing trailing newlines (Multiple files)

Several files are missing trailing newlines:

  • layouts/case-studies/list.html:79
  • layouts/case-studies/single.html:99

Fix: Add a newline at the end of each file.

2. Color token changes - verification needed

The PR changes several color values from violet-600 to violet-700. While the title indicates this aligns with Console color tokens, I recommend verifying:

  • That these specific violet-700 values match the Console design system
  • That all instances have been updated consistently (I see changes in multiple files including index.html, about.html, and various page templates)

Files with violet-600 → violet-700 changes:

  • layouts/case-studies/list.html:27
  • layouts/case-studies/single.html:23
  • layouts/index.html:239
  • layouts/index.html:350
  • layouts/index.html:396-397
  • layouts/page/about.html:87
  • And many more throughout the codebase

3. Indentation changes

The PR includes significant whitespace/indentation reformatting across many HTML template files. While this improves consistency, it makes it harder to review the actual color changes. Consider:

  • Whether all these formatting changes were intentional
  • If future PRs should separate formatting from functional changes

Positive Observations

  • The color changes appear systematic and consistent
  • The scope covers both marketing pages and documentation templates appropriately
  • SCSS variable changes in theme/src/scss/_colors.scss suggest a thoughtful approach to centralizing color tokens

Recommendation

The changes look generally good, but please:

  1. Add trailing newlines to the files listed above
  2. Verify that the violet-700 values match your Console design system specifications
  3. Test the visual appearance of affected pages to ensure the darker violet shade works as intended across all contexts

Need additional reviews or want me to help with fixes? Just mention me (@claude) in a comment.

@pulumi-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants