Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PEP warnings in testing-unittest-py #1411

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

ocworld
Copy link
Contributor

@ocworld ocworld commented Apr 5, 2023

The pr is to fix warnings In testing-unittest-py.
Firstly, fixing warnings about PEP.
Secondly, removing unused import.

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

@ocworld ocworld changed the title fix: in testing-unittest-py, fixing warnings and removing unused import Fix PEP warnings in testing-unittest-py Apr 5, 2023
@cnunciato cnunciato modified the milestones: 0.87, 0.88 Apr 17, 2023
@cnunciato cnunciato removed this from the 0.88 milestone May 13, 2023
Copy link
Member

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ocworld!

@cnunciato cnunciato enabled auto-merge (squash) May 24, 2023 18:51
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

@scottslowe
Copy link
Contributor

/run-example-tests

@github-actions
Copy link

Please view the results of the PR Build Here

@scottslowe
Copy link
Contributor

@cnunciato The only failing tests are the DO and AWS tests that were fixed by #1497 (I kicked off the tests before that PR was merged). I'm OK to merge this if you are.

@cnunciato cnunciato merged commit 6e886de into pulumi:master Jan 23, 2024
4 checks passed
@ocworld ocworld deleted the fix-warnings branch January 23, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants