Omit partial log entries from the raw gRPC log #158
Merged
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaid-Ajaj
reviewed
Nov 19, 2025
Zaid-Ajaj
requested changes
Nov 19, 2025
Contributor
Zaid-Ajaj
left a comment
Zaid-Ajaj
left a comment
There was a problem hiding this comment.
Partial log entry logic should probably account for logs that don't have the progress field i.e. from an older CLI
Contributor
Author
|
Failure is due to the random provider's version floating pulumi/pulumi#19350. Edit: the CLI is also floating... |
Graham-Pedersen
approved these changes
Nov 19, 2025
Zaid-Ajaj
approved these changes
Nov 19, 2025
|
This PR has been shipped in release v0.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #157.
This omits partial log entries from the raw gRPC log, which some providers inspect as part of tests.
A test was made to fail in order to confirm the fix.