Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make prepare updates project url and org name #93

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

gpduck
Copy link
Contributor

@gpduck gpduck commented Dec 1, 2022

This extends make prepare with an ORG command line parameter and updates deployment-teplates/.goreleaser.yml and provider/resources.go to use the key abc as a replacement value for the org name. It also updates those files to use the github.com/pulumi/pulumi-xyz repo value where they weren't already and extends make prepare to replace those values with the REPOSITORY configuration variable (instead of relying on the -xyz replacement as before, which did not properly update the repo location for 3rd party repos).

The only manual modifications remaining are to add the proper upstream terraform go module, define the resource mappings, and set various values in provider/resources.go as required (ie download url, image, etc)

This may be sufficient to close #75

@nimro
Copy link

nimro commented May 30, 2023

Thanks for this, I was having trouble chasing the references down manually. This change helped me get everything working!

@guineveresaenger guineveresaenger added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 10, 2024
@guineveresaenger
Copy link
Contributor

This seems like a solid improvement, and with a testimonial at that. Thank you for your contribution!

Because this pull request is so old (we apologize for the delay!) I've run a rebase for you and requested a review from the team. We can take this change from here.

@guineveresaenger guineveresaenger merged commit 0f798c7 into pulumi:main Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make prepare should also set ORG
3 participants