fix: send SSE connection notice as notifications/message #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iqdoctor
commented
Nov 15, 2025
iqdoctor
commented
- Replace custom "sse/connection" notification with standard "notifications/message"
- Use params {level: "info", data: "SSE Connection established"} to match MCP logging schema
- Avoid pydantic validation errors for unexpected notification method/shape (issue WARNING:root:Failed to validate notification: 13 validation errors for ServerNotification #33)
- Replace custom "sse/connection" notification with standard "notifications/message"
- Use params {level: "info", data: "SSE Connection established"} to match MCP logging schema
- Avoid pydantic validation errors for unexpected notification method/shape (issue punkpeye#33)
Owner
|
Looks like the checks are not passing. |
- Send SSE connection notification as a spec-compliant `notifications/message` with {data, level} payload
- Order params keys as {data, level} to comply with eslint-perfectionist/sort-objects
Contributor
Author
|
Tnx. I simply swapped the order of the |
Owner
|
This is still failing just in case |
Contributor
Author
|
pls apply if after #47 |
Owner
|
#47 merged |
Contributor
Author
|
let me check test results |
Contributor
Author
|
all passed |
Contributor
Author
|
@punkpeye PR ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.