Skip to content

Conversation

@joeferner
Copy link
Contributor

No description provided.

@punkpeye
Copy link
Owner

@joeferner Just need to add a test

@joeferner
Copy link
Contributor Author

@punkpeye I added a unit test. I ended up creating test certificates to fully test the interaction. I ignored them from the npm package to keep things tidy.

.DS_Store
PR-SUBMISSION-GUIDE.md
".claude/"
src/fixtures/certs/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add these to ignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove the ignore, just figured when installing this package don't really need the test certs

@joeferner
Copy link
Contributor Author

Not sure what is going on with the test failure. Looks like a false positive.

@punkpeye punkpeye merged commit c269265 into punkpeye:main Dec 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants