Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dmi.product_version) Additional system information #2671

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Jan 16, 2024

Attempts to fix #2654

@jcpunk jcpunk requested a review from a team as a code owner January 16, 2024 19:26
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@joshcooper joshcooper added the enhancement New feature or enhancement label Jan 30, 2024
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add a dmi.product.version fact to call the new resolver. Similar to how https://github.com/puppetlabs/facter/blob/main/lib/facter/facts/linux/dmi/product/name.rb resolves :product_name

Could you also include the output of bundle exec facter dmi on a test system to verify it's working as expected?

@jcpunk jcpunk force-pushed the dmi_product_version branch from ae5ce2b to 5e66686 Compare January 30, 2024 18:37
@jcpunk
Copy link
Contributor Author

jcpunk commented Jan 30, 2024

[riehecky@leibniz facter]$ bundle exec facter dmi
{
  bios => {
    release_date => "07/19/2023",
    vendor => "Intel Corp.",
    version => "FNCML357.0062.2023.0719.2024"
  },
  board => {
    asset_tag => "Default string",
    manufacturer => "Intel Corporation",
    product => "NUC10i7FNB"
  },
  chassis => {
    asset_tag => "Default string"
  },
  manufacturer => "Intel(R) Client Systems",
  product => {
    name => "NUC10i7FNH",
    version => "K61081-302"
  }
}

@jcpunk jcpunk force-pushed the dmi_product_version branch from 5e66686 to 4dc5f92 Compare January 30, 2024 18:50
@jcpunk jcpunk requested a review from joshcooper January 30, 2024 18:59
@jcpunk jcpunk force-pushed the dmi_product_version branch from 4dc5f92 to cd74e2d Compare January 30, 2024 19:33
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @jcpunk!

@joshcooper joshcooper merged commit 75771c9 into puppetlabs:main Feb 1, 2024
17 checks passed
@jcpunk jcpunk deleted the dmi_product_version branch February 2, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dmidecode system information version field
3 participants