Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BUGFIX) Pin json-schema below 5.1.1 to resolve issues with Ruby 2 on Windows #605

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

david22swan
Copy link
Member

PDK build step is currently failing on Windows with regards to Ruby 2 due to a conflict with the gem bigdecimal which has been brought in by json-schema 5.1.1

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@david22swan david22swan requested a review from a team as a code owner December 12, 2024 10:57
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavindidrichsen gavindidrichsen merged commit e639470 into main Dec 12, 2024
3 checks passed
@gavindidrichsen gavindidrichsen deleted the json-schema branch December 12, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants