Use more mod classes in default_mods #2288
Conversation
|
Hello! 👋 This pull request has been open for a while and has had no recent activity. We've labelled it with If you are waiting on a response from us we will try and address your comments on a future Community Day. Alternatively, if it is no longer relevant to you please close the PR with a comment. Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error. |
ekohl
force-pushed
the
use-include-for-default-mods
branch
from
bbe6b8a
to
5dbcdf4
Compare
@david22swan any thoughts on this? |
|
I can't ping @puppetlabs/modules directly, but I just ran into this again. |
|
@david22swan this isn't ready to merge, but here I could use some opinion. Especially if we're going to do a major release that may be a good time to change the default. |
|
@ekohl Apologies for the wait on reply, from a general viewpoint this looks good to me to go forward though unsure, of the top of my head, how to resolve the issue with expires |
|
It would be a breaking change to change it. I had hoped we could for 9.0.0. Shall I rebase it for now without the expires change and add a comment inline why we don't? |
This prevents duplicate class declarations.
This was already done in default mods, but this removes duplication and allows use without default mods.
This removes duplication in default mods and makes it easy to use without default mods.
ekohl
force-pushed
the
use-include-for-default-mods
branch
from
5dbcdf4
to
a678f3d
Compare
|
@ekohl Yeh, that sounds good. |
|
Well, this is unfortunate. It looks like this PR has gone under our radar while working on our latest major release. We will need to revisit this PR again and find a suitable time to merge it before the next major release. |
The goal is to remove duplication and make it easy to use mod classes where needed. This makes using the module without default mods easier. It also removes duplication.
This is a draft because apache::mod::expires creates a config by default, which is probably not what we want out of the box. I'd like to see a discusion on how to best resolve this.