Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add support for filesystem labels #251

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

unki
Copy link

@unki unki commented Mar 23, 2020

e.g.

    logical_volumes:
      opt:
        size: 20G
        use_fs_label: true

will then lead to

  • formating the filesystem by mkfs.ext4 -L opt /dev/vg-xyz/opt. the most mkfs's implement the -L label-parameter. So it shouldn't be necessary to make it configurable.
  • /etc/fstab entry LABEL=opt /opt ext4 defaults 0 0

@unki unki force-pushed the feature/add-support-for-filesystem-labels branch from 741bd43 to 9fb6304 Compare March 24, 2020 07:37
@unki unki force-pushed the feature/add-support-for-filesystem-labels branch from 5d23c8c to 012fb13 Compare April 5, 2020 17:39
@unki unki force-pushed the feature/add-support-for-filesystem-labels branch from 012fb13 to d862320 Compare December 6, 2020 09:01
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@unki unki closed this Feb 24, 2021
@unki unki reopened this Feb 24, 2021
@puppet-community-rangefinder
Copy link

lvm::logical_volume is a type

Breaking changes to this file WILL impact these 1 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

lvm::volume_group is a type

Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 11 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@unki unki force-pushed the feature/add-support-for-filesystem-labels branch from d862320 to 74012bd Compare February 24, 2021 18:43
@unki unki force-pushed the feature/add-support-for-filesystem-labels branch from 74012bd to d6aa0eb Compare February 24, 2021 18:43
@unki
Copy link
Author

unki commented Feb 24, 2021

failing tests are afaics not related to my changes.
possibly gets fixed by #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants