lvm_support: update fact to use --no-headings#259
Closed
b4ldr wants to merge 1 commit intopuppetlabs:mainfrom
Closed
lvm_support: update fact to use --no-headings#259b4ldr wants to merge 1 commit intopuppetlabs:mainfrom
b4ldr wants to merge 1 commit intopuppetlabs:mainfrom
Conversation
b4ldr
force-pushed
the
pv_name_no_headings
branch
2 times, most recently
from
f175796 to
c248f64
Compare
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=======================================
Coverage 72.96% 72.96%
=======================================
Files 17 17
Lines 773 773
=======================================
Hits 564 564
Misses 209 209
Continue to review full report at Codecov.
|
b4ldr
force-pushed
the
pv_name_no_headings
branch
from
c248f64 to
474f321
Compare
I noticed upgrading that the `lvm_vg_#{vg}_pv` facts dose not use
the `--no-headings` switch like the other facts.
This PR adds the `--no-headings` switch and simplifies the collection
b4ldr
force-pushed
the
pv_name_no_headings
branch
from
474f321 to
1b8ba45
Compare
|
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed upgrading that the
lvm_vg_#{vg}_pvfacts dose not usethe
--no-headingsswitch like the other facts.This PR adds the
--no-headingsswitch and simplifies the collection