Skip to content

Conversation

@corlard3y
Copy link
Collaborator

Pull Request Template

Ticket Number

Description

Update Stats to Vault

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

In the PointsVaultListContainer.tsx file:

  1. In the useState for debouncedQuery, instead of setting an empty object, initialize it with an empty string like this:

    const [debouncedQuery, setDebouncedQuery] = useState('');
  2. There is a missing closing brace for the conditional rendering of userStats:

    {userStats && (
       ...
    )}
  3. There are several instances where the Text component is missing its closing tag. Make sure to close the Text component properly.

  4. In the Text component where you mention 'Total Users with Email', the text should be wrapped within curly braces and not angle brackets. Also, ensure the .toLocaleString() is correctly used after accessing the respective value from userStats for all instances.

  5. In the Link component to Twitter, the text '@PushProtocol' should be wrapped in curly braces or quotation marks to make it a string.

  6. The img tag for PushIcon should have an alt attribute for accessibility.

In the rewards.ts file:

  1. In the UserRewardsStatsResponse type, the allSeasons object is missing its property definitions. Add the missing properties for allSeasons.

  2. In the UserRewardsDetailParams type, there is a missing closing brace after the caip10WalletAddress property.

  3. In the createUserRewardsDetailResponse type, it currently has an empty object as a value. Ensure this structure fits the expected response for user rewards details.

Overall, please fix the mentioned issues in the code. After the necessary corrections, please perform testing to ensure everything works as expected.

All looks good.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2026-01-07 11:05 UTC

riyanshu-patro
riyanshu-patro previously approved these changes Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

In PointsVaultListContainer.tsx:

  1. Typo: 'blocks' should be 'Block'.
  2. Typo: 'snap' should be 'svg'.
  3. In the useGetUserRewardsStats hook, data: userStats should be const { data: userStats } = useGetUserRewardsStats();.
  4. In the JSX, <Box> element is missing its closing tag in the 'Total Users' portion.
  5. In the JSX, variant="bs-semibold" should be corrected to the appropriate value.
  6. In the JSX, {userStats.allSeasons.totalUniqueUsers?.toLocaleString()} is missing a closing tag for <Text>.
  7. In the JSX, 'Total Users with Email' should be enclosed in a <Text> tag.
  8. In the JSX, {userStats.allSeasons.totalUniqueUsersWithEmail?.toLocaleString()} is missing a closing tag for <Text>.
  9. In the JSX, 'Season 2' should be enclosed in a <Text> tag.
  10. In the JSX, {userStats.seasonTwo.totalUsers?.toLocaleString()} is missing a closing tag for <Text>.
  11. In the JSX, {userStats.seasonTwo.totalUsersWithEmail?.toLocaleString()} is missing a closing tag for <Text>.
  12. In the JSX, 'Season 1' should be enclosed in a <Text> tag.
  13. In the JSX, {userStats.seasonOne.totalUsers?.toLocaleString()} is missing a closing tag for <Text>.
  14. In the JSX, {userStats.seasonOne.totalUsersWithEmail?.toLocaleString()} is missing a closing tag for <Text>.
  15. In the JSX, 'Ensure the user has at-least 50 Followers and is following' is missing a complete <Text> tag.
  16. 'on Twitter' should be enclosed in a <Text> tag.
  17. Missing closing tag for the <img> element.

In rewards.ts:

  1. UserRewardsDetailParams is missing a closing curly brace.
  2. UserRewardsDetailResponse is missing closing curly brace for the seasonOne and seasonTwo objects.
  3. UserRewardsStatsResponse is missing closing curly brace for the seasonTwo object.
  4. UserRewardsStatsResponse is missing closing curly brace for the allSeasons object.
  5. createUserRewardsDetailParams is missing } to close the property declaration.
  6. LeaderBoardUser type is incomplete.
  7. ModelledLeaderBoardUser type is incomplete.
  8. LeaderboardResponse is missing closing curly brace for the users array.
  9. LeaderboardModelledResponse is incomplete.

Please correct these issues in the respective files.

@riyanshu-patro riyanshu-patro merged commit 96dd5db into main Jan 7, 2026
2 checks passed
@riyanshu-patro riyanshu-patro deleted the fixVaultIssues branch January 7, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants