fix: add Bookmarks link to mobile hamburger menu - #356
Open
peace4m wants to merge 1 commit into
Open
Conversation
Contributor
|
@peace4m is attempting to deploy a commit to the PushkarScripts Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #328
Description
Added the missing "BOOKMARKS" link to the mobile hamburger menu drawer in
app/components/navbar.tsx. The link now matches the desktop navigation and includes theonClickhandler to properly close the menu upon navigation.Type of Change
Screenshots / Demo
Visible in browser DevTools when switching to a mobile viewport and opening the hamburger menu.
How Has This Been Tested?
Ran the app locally using
npm run dev. Opened the site in browser DevTools, switched to a mobile device view, and toggled the hamburger menu. Verified that the 'BOOKMARKS' link is present, styled correctly, and navigates to/bookmarkswhile closing the menu.Checklist
AI Usage
I have not used AI tools for this contribution
I have used AI tools (ChatGPT, Copilot, Claude, etc.) and I have reviewed, verified, and understood all generated code/content before submitting this PR
If AI tools were used, briefly explain how:
Used an AI assistant to help locate the bug in the component structure, review the React code, and format this pull request description. I manually applied the code changes in my local IDE (WebStorm) and tested the fix in the browser.
Additional Notes
Thanks for maintaining this project!