Skip to content

Draft: maps#23

Draft
puzzlewolf wants to merge 3 commits intomainfrom
nora/maps
Draft

Draft: maps#23
puzzlewolf wants to merge 3 commits intomainfrom
nora/maps

Conversation

@puzzlewolf
Copy link
Owner

@puzzlewolf puzzlewolf commented Feb 6, 2022

Use leaflet.js to embed an OpenStreetMap map, if the lat and long fields of a concert are populated. I found another project (https://github.com/xtk93x/Leaflet.TileLayer.ColorFilter) to change the map colors to match or theme more closely, I think it looks nice :)

GDPR requires claiming legitimate use. Others do so, e.g. here, and the OSM foundation says the same.

Remaining todo:

  • css for the map widget, I just hardcoded width=100% and chose a random height that looked okay
  • we could use a different color for the marker and links in the copyright line?
  • I think a user expects the map link somewhere, mostly probably google maps. Do we want to do that? Where else?
  • Add language to privacy statement

@netlify
Copy link

netlify bot commented Feb 6, 2022

✔️ Deploy Preview for agitated-sinoussi-fd6eb8 ready!

🔨 Explore the source changes: 028fa08

🔍 Inspect the deploy log: https://app.netlify.com/sites/agitated-sinoussi-fd6eb8/deploys/62237a7d2f69c90007cd29b8

😎 Browse the preview: https://deploy-preview-23--agitated-sinoussi-fd6eb8.netlify.app

@puzzlewolf puzzlewolf marked this pull request as draft February 6, 2022 02:15
@puzzlewolf puzzlewolf force-pushed the nora/maps branch 4 times, most recently from a2d8a11 to 0d61e61 Compare February 6, 2022 12:56
@puzzlewolf puzzlewolf requested a review from heinrob February 6, 2022 13:09
@puzzlewolf puzzlewolf force-pushed the nora/maps branch 3 times, most recently from 197382e to 1630617 Compare February 7, 2022 08:36
@heinrob
Copy link
Collaborator

heinrob commented Feb 13, 2022

Remaining todo:

* [ ]  css for the map widget, I just hardcoded `width=100%` and chose a random height that looked okay

I think we want to merge the general concert layout and the map branch to have a two column layout. Or is it weird to have a map in portrait format?

* [ ]  we could use a different color for the marker and links in the copyright line?

Maybe some kind of corporate color scheme? Hovering over links is colored too, maybe we can pick a small palette?
The Adobe Color wheel yields 5 colors always matching quite nicely, which should be enough to start with.

* [ ]  I think a user expects the map link somewhere, mostly probably google maps. Do we want to do that? Where else?

Do you mean when the user clicks on the map?

* [ ]  Add language to privacy statement

@puzzlewolf
Copy link
Owner Author

puzzlewolf commented Feb 22, 2022

Remaining todo:

* [ ]  css for the map widget, I just hardcoded `width=100%` and chose a random height that looked okay

I think we want to merge the general concert layout and the map branch to have a two column layout. Or is it weird to have a map in portrait format?

You can merge the new layout, rebase this PR and figure out the map layout. We'll have to see if portrait maps are too weird :)

* [ ]  we could use a different color for the marker and links in the copyright line?

Maybe some kind of corporate color scheme? Hovering over links is colored too, maybe we can pick a small palette? The Adobe Color wheel yields 5 colors always matching quite nicely, which should be enough to start with.

I'm not sure I'd want to spend time on that. The blues aren't too different, good enough for me right now. Thanks for creating #28, for later :)

* [ ]  I think a user expects the map link somewhere, mostly probably google maps. Do we want to do that? Where else?

Do you mean when the user clicks on the map?

Yes. I found qwant maps. It's made in France, FOSS, privacy preserving, uses OSM, looks nice and seems to have a decent navigation. What do you think?

* [ ]  Add language to privacy statement

Meh, yes. Will add this later today

@puzzlewolf puzzlewolf force-pushed the nora/maps branch 2 times, most recently from d0079f3 to 3837a89 Compare March 5, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants