Skip to content

Conversation

@kandersolar
Copy link
Member

Note that pvfactors_timeseries (actually solarfactors under the hood) uses the old names, so the pvfactors tests are going to fail until solarfactors is updated and a new version released.

@ramaroesilva
Copy link
Contributor

ramaroesilva commented Dec 21, 2025

@kandersolar nice to see this moving! Will this be done also for isotropic, klucher, reindl, and king? I also noticed that the last two have "poa_" in the docstring but not on the actual variable within the code.

Also, I guess I should address #1553 (which is being handled here #2527) on top of this right? Once you comment on my first question (and it is addressed, if I'm right) I can later review this PR, so that its merging is sped up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "poa_" prefix to return_components=True transposition model outputs

2 participants