-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add methods and tests for a explicit IV curve calculation of single-diode model #409
Changes from all commits
22d2e5c
bb7c49a
36d4f78
817a303
b17a8cd
0666d29
595e254
5ade588
7179096
4b66f87
664d7d8
09a9e14
06be522
1aba56a
f09be91
4905363
a3d2bb4
8ee1b94
c9a893a
c5248bb
68c65c3
41e0c83
d7b6e62
aa3d29a
9fc350d
54e8d18
16ad9b4
7aca302
086e73f
9f2b157
555e946
52a8e88
c0e18a5
09c6a75
ff8cc0b
446fa9e
f976f61
db88022
a509dd3
62010c2
5c939b8
66a801d
df1423b
eb20cf4
e3805ef
5f89578
ba84fcf
0f3893c
d6023b1
80b3352
ef20676
98d1c01
4ecd913
bf05d2d
edc445d
f542d15
cc6c976
22c53fc
442a3d4
6bcffe8
e6b60c6
0fc9c83
fc6cee1
28c8ffb
58361c1
5f9ed41
43475cc
c79ab97
1ad6031
f14ba04
8d86560
337d7b4
ce5b0f5
3e009f8
082dfd5
ceb69cd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
# Byte-compiled / optimized / DLL files | ||
.pytest_cache/ | ||
__pycache__/ | ||
*.py[cod] | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,7 +65,6 @@ algorithm. | |
|
||
spa | ||
|
||
|
||
Correlations and analytical expressions for low precision solar position | ||
calculations. | ||
|
||
|
@@ -80,6 +79,7 @@ calculations. | |
solarposition.equation_of_time_pvcdrom | ||
solarposition.hour_angle | ||
|
||
|
||
Clear sky | ||
========= | ||
|
||
|
@@ -206,6 +206,18 @@ Functions relevant for the single diode model. | |
pvsystem.i_from_v | ||
pvsystem.singlediode | ||
pvsystem.v_from_i | ||
pvsystem.max_power_point | ||
|
||
Low-level functions for solving the single diode equation. | ||
|
||
.. autosummary:: | ||
:toctree: generated/ | ||
|
||
singlediode_methods.estimate_voc | ||
singlediode_methods.bishop88 | ||
singlediode_methods.bishop88_i_from_v | ||
singlediode_methods.bishop88_v_from_i | ||
singlediode_methods.bishop88_mpp | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "methods" makes me think of methods vs. functions but maybe that's just me. probably best to go with it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That was my thought, also, but in this case I think it's OK. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can change this to "how" I think that's what Pandas often uses. Is there any precedent for PVLIB? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You mean There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm ok with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LOL! I meant the keyword, but I'm fine with everything as it is if you are. |
||
|
||
SAPM model | ||
---------- | ||
|
@@ -232,7 +244,6 @@ PVWatts model | |
pvsystem.pvwatts_ac | ||
pvsystem.pvwatts_losses | ||
|
||
|
||
Other | ||
----- | ||
|
||
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwhanse you once asked for a more specific function name. Does encapsulating the function within a singlediode module address that concern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with
bishop88
here as a member ofsinglediode_methods
. It's siblings will belambertw
and perhaps others.